hooks: Add option to disable TLS verification#1359
Open
Conversation
Acconut
reviewed
Mar 30, 2026
Acconut
reviewed
Apr 29, 2026
Comment on lines
+57
to
+60
| TLSClientConfig: &tls.Config{ | ||
| InsecureSkipVerify: h.Insecure, | ||
| }, | ||
| } |
Member
There was a problem hiding this comment.
Let's do it like this, so we keep the default TLS config for most use cases:
Suggested change
| TLSClientConfig: &tls.Config{ | |
| InsecureSkipVerify: h.Insecure, | |
| }, | |
| } | |
| } | |
| if h.Insecure { | |
| client.Transport.TLSClientConfig = &tls.Config{ | |
| InsecureSkipVerify: true, | |
| } | |
| } |
Author
There was a problem hiding this comment.
Transport is a http.RoundTripper and it would require casting like this. I changed the assignment a bit to avoid it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
hooks-http-insecureflag to the CLI andInsecurefield toHttpHookstruct.If you are wondering, why
ForceAttemptHTTP2: true,was added tohttp.Transport:Resolves #1335