With sounds #2
Open
With sounds #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the .sh file to play notification sound when needed. Also informed the updates in the README.md file.
Contributor
Author
|
Here I wished things to work but I can't get the sound notification. Also I don't get notification in full screen mode. Is there a possible solution? |
… have prevented the sound playing
Owner
|
@OAtulA Thanks for checking out this repo. I really appreciate your efforts. I was little busy, so missed to answer your queries. Adding sound feature is great idea. I am planning to declare some common variable for sound file, before the while loop, I will make changes in your pull-request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't get this.