V0.1.1 : pytest for BigQueryToCSV.extract() #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thu Oct 24 9:25 PM IST
… guiding users to resolution ETAs eventually
…e repository for resolution
…nical specifications.
11 tasks
rakhioza07
requested changes
Nov 4, 2024
| and config.metadata["source"]["engine"] == SupportedEngine.BIGQUERY.value | ||
| ): | ||
| data_loader = BigQueryToCSV(config=config) | ||
| data_loader.load() |
|
Please Add Test case for the following functionalities :
|
tusharchou
commented
Nov 20, 2024
| session_catalog=catalog, | ||
| identifier = identifier | ||
| ) | ||
| stats = table_statistics_from_iceberg_metadata( |
There was a problem hiding this comment.
#1 I am trying to solve for the statistics here @rakhioza07 @redpheonixx
11 tasks
tusharchou
commented
Nov 23, 2024
| from local_data_platform.store.dimension import Dimension | ||
| from local_data_platform.product.vocab import Vocab | ||
|
|
||
| def test_get(): |
There was a problem hiding this comment.
Love how simple this is 🥇
topic: pyiceberg subject: table.scan().count() to-do: implement table.scan().count() eta: Nov 28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this test and the code changes along with it
name: Pull request
about: Implement an solution for this project
title: ''
labels: ''
assignees: ''
Is your pull request related to a issue? Please tag.
Describe the solution you have implemented
Describe why alternatives you considered are not optimal
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the pull request here.