Sourcery Starbot ⭐ refactored tusharmakkar08/Imagyy #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Apr 7, 2020
| user_id = username.split('=')[1] | ||
| facebook_image_search("", user_id, directory_to_download=args['directory']) | ||
| else: | ||
| facebook_image_search(username, directory_to_download=args['directory']) |
Author
There was a problem hiding this comment.
Function command_line_runner refactored with the following changes:
- Remove redundant conditional
| webbrowser.open_new_tab(new_url) | ||
| _open_image_page(user_id) | ||
| _open_profile_pic(user_id) | ||
| if not directory_to_download: |
Author
There was a problem hiding this comment.
Function facebook_image_search refactored with the following changes:
- Swap positions of nested conditionals
- Hoist repeated code outside conditional statement
- Replace if statement with if expression
|
Hi Tushar - would love to know what in particular you're not happy with. GitHub reviews are new for us and we're keen to improve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: