-
Notifications
You must be signed in to change notification settings - Fork 600
Update size tokens and classes #9904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YohYamasaki
wants to merge
7
commits into
master
Choose a base branch
from
update-size-tokens
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
890d693 to
9caa950
Compare
792304f to
ae9be04
Compare
charlag
approved these changes
Nov 13, 2025
Contributor
charlag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good as far as I'm concerned! thank you!
| column_resize_element_width: 5, | ||
| } | ||
|
|
||
| export const component_size = { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea to split it up!
8184129 to
99263d7
Compare
General - Do auto-login after the signup completion Only create persistent session after recovery code was shown - Extend new account creation process to cover gift cards Language - Use the website's language when it is passed by the query param - Add language selector in the login page - Make dropdown to resize dynamically on filtering - Replace dropdown filter input with `SingleLineTextField` - Reverse dropdown content based on render-direction (up/down) - Add a Link style dropdown selector for LoginInfoLinks Plan selector - Fix plan selector to remember the selected plan during the flow Form - Disable button when checkbox is missing in the signup form - Remove age checkbox from signup form - Remove privacy policy checkbox from the Terms of Service agreement Payment page - Refactor Payment Switcher and remove PaymentMethodInput.ts - Auto-continue on Paypal account connection - Save Paypal billing agreement as shares state after connecting - Update Countrylist to be all in english Deutschland -> Germany - Re-enable country locator service to show the correct country Co-authored-by: nig <nig@tutao.de> Co-authored-by: toj <toj@tutao.de> Co-authored-by: yoy <yoy@tutao.de> Co-authored-by: hak <hak@tutao.de>
since we're removing the age checkbox from signup, we have to add it to the usage test opt-in since we can't get consent for that from someone that's 15 or younger (it has to be a legal guardian). We accomplish this by adding the checkbox as a required step to activate usage tests from the news item and with a new dialog that asks for confirmation after selecting "Activated" in the settings.
Co-authored-by: Yohei <yoy@tutao.de>
99263d7 to
ea6c022
Compare
- Update the size tokens to use multiple of 4px - Update the spacing related classes' suffix to use the px sizes (i.e. mt-s -> mt-4, pb-l -> pb-32)
ea6c022 to
593e0a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9903