CMake: tuttle common/host depend on different boost libraries #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 14, 2015 13:42
* include_directories: add include directories to the build. * target_include_directories: add include directories to a target.
* boost regex is only used in sequenceParser (which is an other project according to CMake). * boost thread is not used.
* Only used for one function: boost::program_options::split_unix. * Can be replaced by our own code.
Contributor
There was a problem hiding this comment.
May be you could use functions of the std library to split the string ?
Member
Author
There was a problem hiding this comment.
Yes std::string::find_first_of seems to be a good solution.
Done here 8965ae9
added 2 commits
October 16, 2015 15:22
cchampet
added a commit
that referenced
this pull request
Oct 23, 2015
CMake: tuttle common/host depend on different boost libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #475