Conversation
Contributor
|
Thanks for the contribution. I was thinking about an extension with several color themes, w/o a doubt will add your pack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read more here: https://github.com/ZeroBug-ZB/tvjs-xp/tree/main/src/extensions/darkside
Please note that using:
<trading-vue :data="dc" :extensions="ext" skin="darkside"/>cause following crash:
client.js?06a0:96 TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator)) at shaders_createForOfIteratorHelper (trading-vue.js?0042:13465) at VueComponent.init_shaders (trading-vue.js?0042:13481) at VueComponent.mounted (trading-vue.js?0042:13575) at invokeWithErrorHandling (vue.runtime.esm.js?2b0e:1854) at callHook (vue.runtime.esm.js?2b0e:4219) at Object.insert (vue.runtime.esm.js?2b0e:3139) at invokeInsertHook (vue.runtime.esm.js?2b0e:6346) at VueComponent.patch [as __patch__] (vue.runtime.esm.js?2b0e:6565) at VueComponent.Vue._update (vue.runtime.esm.js?2b0e:3948) at VueComponent.updateComponent (vue.runtime.esm.js?2b0e:4060)After some debugging, it seems a problem related to the automatic builded "tvjs-xp.js" and not related to the extension/skin itself.