fix: use class primarily and skip className if preact/compat is imported#21
Open
riywo wants to merge 1 commit intotw-in-js:mainfrom
Open
fix: use class primarily and skip className if preact/compat is imported#21riywo wants to merge 1 commit intotw-in-js:mainfrom
riywo wants to merge 1 commit intotw-in-js:mainfrom
Conversation
preact/compat changes `className` to a synonym of `class`. Thus, we only need this setup when preact/compat isn't imported.
|
@sastan @danielweck @eldain @Trugamr are y'all still the active maintainers and can this PR be merged? I'm encountering the same issue as @riywo did where twind is trying to set the className and gets a TypeError. Would love if this fix could be merged in. |
|
Ah actually I retract this statement, I tried running the modified library and it did not fix my issue. Got the fix when I removed my imports of React components from a diff library unrelated to twind. So this likely does not need to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preact/compat changes
classNameto a synonym ofclass.Thus, we only need this setup when preact/compat isn't imported.
This change fixes failure when preact/compat is used and the component is re-rendered. Close #20
Testings
Confirmed this worked with https://codesandbox.io/s/rrjq1?file=/public/index.js locally with workspace of this package.
If you want to see the working fix, I can update the code sandbox.