Skip to content

Conversation

@coliff
Copy link
Contributor

@coliff coliff commented Jan 26, 2026

Description

Introduced new sections for Collapse and Placeholders components in the cheatsheet example page, including navigation links and example usage for each component.

Ideally we'd update the RTL page too but I don't have translations for the components. Shall we use auto-translate for it?

Motivation & Context

Cheatsheet page is really useful to see all the components on a single page and Collapse and Placeholders were missing.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Copilot AI review requested due to automatic review settings January 26, 2026 06:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds two missing Bootstrap component sections (Collapse and Placeholders) to the cheatsheet example page, making it more comprehensive for developers who use it as a quick reference.

Changes:

  • Added navigation links for Collapse and Placeholders components in the sidebar menu
  • Added Collapse component section with standard toggle example
  • Added Placeholders component section with card skeleton loader example

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coliff coliff marked this pull request as draft January 26, 2026 06:27
@coliff
Copy link
Contributor Author

coliff commented Jan 26, 2026

I think some of the failing tests are unrelated to my changes.

command used: java -jar "/home/runner/work/bootstrap/bootstrap/node_modules/vnu-jar/build/dist/vnu.jar" --asciiquotes --skip-non-html --Werror --filterpattern "Attribute “autocomplete” is only allowed when the input type is.*|
Attribute “autocomplete” not allowed on element “button” at this point.|
An “aria-disabled” attribute whose value is “true” should not be specified on an “a” element that has an “href” attribute.|Attribute “is:raw” is not serializable as XML 1.0.|
Attribute “is:raw” not allowed on element “code” at this point.|
Trailing slash on void elements has no effect and interacts badly with unquoted attribute values.|
Attribute “switch” not allowed on element “input” at this point." _site/ js/tests/
"file:/home/runner/work/bootstrap/bootstrap/_site/docs/5.3/examples/cheatsheet/index.html":1141.13-1141.52: info warning: Empty heading.

@julien-deramond
Copy link
Member

"file:/home/runner/work/bootstrap/bootstrap/_site/docs/5.3/examples/cheatsheet/index.html":1141.13-1141.52: info warning: Empty heading.

Can't run it locally right now, but it might come from the following empty heading:

<h5 class="card-title placeholder-glow">
  <span class="placeholder col-6"></span>
</h5>

Introduced new sections for Collapse and Placeholders components in the cheatsheet example page, including navigation links and example usage for each component.

Update site/src/assets/examples/cheatsheet/index.astro

Update site/src/assets/examples/cheatsheet/index.astro

Update index.astro

Co-Authored-By: Copilot <[email protected]>
@coliff coliff force-pushed the dev/coliff/add-placeholder-collapse-cheatsheet branch from b24a022 to a3e2811 Compare January 26, 2026 07:28
@coliff
Copy link
Contributor Author

coliff commented Jan 26, 2026

thanks for that pointer! I noticed the Placeholder example actually uses the following code, so I updated it and squashed the commits:

<div class="h5 card-title placeholder-glow">
  <span class="placeholder col-6"></span>
</div>

@coliff coliff marked this pull request as ready for review January 26, 2026 07:31
@github-project-automation github-project-automation bot moved this to Needs review in v5.4.0 Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

2 participants