Skip to content

Drop Collapse trigger .collapsed state and rely on aria-expanded - #42740

Closed
julien-deramond wants to merge 1 commit into
v6-devfrom
v6-dev-jd-drop-collapsed-class-from-collapse-component
Closed

Drop Collapse trigger .collapsed state and rely on aria-expanded#42740
julien-deramond wants to merge 1 commit into
v6-devfrom
v6-dev-jd-drop-collapsed-class-from-collapse-component

Conversation

@julien-deramond

@julien-deramond julien-deramond commented Jul 23, 2026

Copy link
Copy Markdown
Member

Description

This PR removes the Collapse plugin’s dependency on the trigger .collapsed class and standardizes trigger state on aria-expanded.

aria-expanded already represents the canonical open/closed state, while .collapsed was redundant and could drift from accessibility/state logic in custom scripts and selectors. This change simplifies the API surface, keeps behavior aligned with accessible state, and updates tests/docs/examples accordingly.

Live previews

@mdo

mdo commented Jul 28, 2026

Copy link
Copy Markdown
Member

Thanks @julien-deramond! I rebased this onto the current v6-dev, where js/src/collapse.js has become js/src/collapse.ts, and opened #42771 to carry it forward with you credited as co-author.

Closing this one as superseded by #42771.

@mdo mdo closed this Jul 28, 2026
@julien-deramond
julien-deramond deleted the v6-dev-jd-drop-collapsed-class-from-collapse-component branch July 29, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants