Guard placeholder glow/wave animations behind prefers-reduced-motion - #42768
Merged
Conversation
julien-deramond
marked this pull request as ready for review
July 28, 2026 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.placeholder-glowand.placeholder-waveuse an infinite 2s CSS animation to create their loading-shimmer effect. Unlike every other looping animation in the codebase, these two had no way to opt out for users who haveprefers-reduced-motion: reduceset in their OS/browser. It's a real accessibility gap for anyone sensitive to motion.This PR closes that gap by wrapping both animations in the same reduced-motion guard used elsewhere in the project.
.placeholder-glow's animation and.placeholder-wave's animation are now disabled (animation: none) inside@media (prefers-reduced-motion: reduce).@if $enable-reduced-motionso it can still be compiled out entirely via the existing Sass config flag, consistent with how_progress.scss,_spinner.scss, and the sharedtransition()mixin inmixins/_transition.scssalready handle this.Note
This might worth checking v5 to backport this modification if not already handled
How to test
On macOS, it's easily testable by enabling/disabling motion in Accessibility settings.