Fix off-scale spacing values flagged in #42907 - #42911
Closed
bobby404-K wants to merge 1 commit into
Closed
Conversation
Docs site (site/src/scss/*.scss): snapped literal spacing values (.125rem, .75rem, 1.25rem, 2rem, 15px) to the nearest step on the inferred scale (0, .25rem, .5rem, 1rem, 1.5rem, 3rem). These are cosmetic/unshipped so resizing is low risk. Core library (scss/_variables.scss, scss/_reboot.scss): .75rem and .125rem recur consistently across unrelated components (button, navbar-toggler, pagination, and toast padding-x; form-check margin and dropdown offset), which reads as intentional undocumented tokens rather than drift. Resizing these would visibly change shipped component appearance for every Bootstrap consumer, so instead they're formalized as named variables derived from $spacer ($spacer-tight, $spacer-hairline) with no visual change. Same treatment for the single 2rem list-indent literal in _reboot.scss (-> $list-indent). Verified: both scss/bootstrap.scss and site/src/scss/docs.scss compile cleanly with dart-sass.
bobby404-K
force-pushed
the
fix/spacing-scale-audit-42907
branch
from
September 7, 2026 15:02
8484ebe to
e6691e2
Compare
Member
|
Thanks for this PR but we won't change impacting things in |
Author
|
Makes total sense, thanks for taking a look! Given v6 is close, I don't want to add noise to a version that's winding down. Happy to close this out on my end — or if it'd be useful, I could look at whether the same off-scale values still show up on the v6 branch and open something there instead. Let me know whichever's more helpful, and no worries either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs site (site/src/scss/*.scss): snapped literal spacing values (.125rem, .75rem, 1.25rem, 2rem, 15px) to the nearest step on the inferred scale (0, .25rem, .5rem, 1rem, 1.5rem, 3rem). These are cosmetic/unshipped so resizing is low risk.
Core library (scss/_variables.scss, scss/_reboot.scss): .75rem and .125rem recur consistently across unrelated components (button, navbar-toggler, pagination, and toast padding-x; form-check margin and dropdown offset), which reads as intentional undocumented tokens rather than drift. Resizing these would visibly change shipped component appearance for every Bootstrap consumer, so instead they're formalized as named variables derived from $spacer ($spacer-tight, $spacer-hairline) with no visual change. Same treatment for the single 2rem list-indent literal in _reboot.scss (-> $list-indent).
Verified: both scss/bootstrap.scss and site/src/scss/docs.scss compile cleanly with dart-sass.
Description
Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Related issues