Add namespaces #10
Open
Add namespaces #10
+1,086
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nc6
requested changes
Nov 28, 2025
Member
nc6
left a comment
nc6
left a comment
There was a problem hiding this comment.
Few things look wrong here or could do with some additional documentation
CIP-0165/namespaces/README.md
Outdated
| | drep | DRep state | TBD | | ||
| | gov | Governance action state | 0 | | ||
| | hdr | Header state (e.g. nonces) | TBD | | ||
| | Shortname | Content | Key size | |
Member
There was a problem hiding this comment.
Would be nice to add the key description to this table as well?
CIP-0165/namespaces/README.md
Outdated
| | hdr | Header state (e.g. nonces) | TBD | | ||
| | Shortname | Content | Key size | | ||
| | -------------------- | ------------------------------- | -------- | | ||
| | blocks/v0 | Reward accounts | 36 | |
Member
There was a problem hiding this comment.
This isn't reward accounts, it's blocks made, right?
Member
There was a problem hiding this comment.
Also, the key size - this is 28-byte keyhash + 8 byte epoch no?
| @@ -0,0 +1,4 @@ | |||
| ; This file was auto-generated from huddle. Please do not modify it directly! | |||
|
|
|||
| record_entry = int | |||
| @@ -0,0 +1,26 @@ | |||
| ; This file was auto-generated from huddle. Please do not modify it directly! | |||
|
|
|||
| ; Constinution record entry | |||
Member
There was a problem hiding this comment.
Suggested change
| ; Constinution record entry | |
| ; Constitution record entry |
| ; fut0 stands for possible future | ||
| ; fut1 stands for definite future | ||
| ; | ||
| ; fut0 + no pparams is not represented, key should be omitted in that case |
Collaborator
Author
There was a problem hiding this comment.
I've added a string here but we could keep byte as well.
Collaborator
Author
|
I've addressed all the comments and added specks for keys. Discussion items:
|
Collaborator
Author
|
I've updated namespaces and text, and this it's ready for an additional iteration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add namespaces to the CIP