Extend information for the known Namespaces #105
Merged
+30
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduce a structure for the information about the namespaces NamespaceInfo, that keeps an information and configuration for the namespaces. Currently there are only two fields, but they can be excended later: 1. namespaceSpec - Huddle specification for the namespace 2. namespaceKeySize - size of the key We need the latter because in the CIP we propose that all the keys in the namespaces have a statically known size. This way we can pass this information. We use GHC Natural because later we will need that info to pass the values on the type level.
qnikst
added this to the
Milestone 2 : Developpement of Haskell serialization code milestone
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the namespaces data structure to include additional metadata beyond just the CDDL specification. The key change is introducing a NamespaceInfo record type that holds both the namespace specification and key size information.
- Introduced
NamespaceInfodata type to encapsulate namespace metadata (specification and key size) - Updated
namespacesmap fromMap String HuddletoMap Text NamespaceInfo - Refactored all consumers of
namespacesto extract fields from the newNamespaceInfostructure
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scls-cddl/cddl-src/Cardano/SCLS/CDDL.hs | Defines new NamespaceInfo data type and updates namespaces map to use Text keys and NamespaceInfo values |
| scls-cddl/scls-cddl.cabal | Adds text dependency to both library and executable |
| scls-cddl/gen-cddl/Main.hs | Updates to destructure NamespaceInfo and use Text namespace keys |
| scls-format/test/Roundtrip.hs | Updates pattern matching to use Namespace.fromText and namespaceSpec field accessor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joaosreis
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce a structure for the information about the namespaces NamespaceInfo, that keeps an information and configuration for the namespaces.
Currently there are only two fields, but they can be excended later:
We need the latter because in the CIP we propose that all the keys in the namespaces have a statically known size. This way we can pass this information.
We use GHC Natural because later we will need that info to pass the values on the type level.