Loosen requirements for serializer: only keys should be Ord #106
+16
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in a code we required entire value to have an Ord instance. While it's possible to have such one it leads to problems when we work with generic values of the types we do not know. The other problem is that during the computation we should check the equality for the keys only and do not allow two values with the same key even if they are not equal. So the new type reflects that properly.
qnikst
added this to the
Milestone 2 : Developpement of Haskell serialization code milestone
There was a problem hiding this comment.
Pull Request Overview
This PR refactors constraint handling in serialization code to support types with separate key types. Instead of requiring the entire type a to be Ord, it changes constraints to require Ord (Key a), where Key a is the associated type from the HasKey typeclass.
- Changed type constraints from
Ord atoOrd (Key a)throughout serialization interfaces - Updated sorting logic to use
sortBy (compare \on` getKey)instead of directsort` - Extracted common finalization logic into a named helper function
finalizeVectorin External/Impl.hs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scls-format/src/Cardano/SCLS/Internal/Serializer/Reference/Impl.hs | Updated type constraints and sorting to use keys; added Data.Function (on) import |
| scls-format/src/Cardano/SCLS/Internal/Serializer/External/Impl.hs | Updated type constraints, added on to imports, refactored duplicate sorting code into finalizeVector helper |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in a code we required entire value to have an Ord instance. While it's possible to have such one it leads to problems when we work with generic values of the types we do not know.
The other problem is that during the computation we should check the equality for the keys only and do not allow two values with the same key even if they are not equal. So the new type reflects that properly.