Skip to content

Bump cuddle to 1.8.0.0#304

Merged
joaosreis merged 1 commit into
mainfrom
bump-cuddle-1.8.0.0
May 18, 2026
Merged

Bump cuddle to 1.8.0.0#304
joaosreis merged 1 commit into
mainfrom
bump-cuddle-1.8.0.0

Conversation

@joaosreis

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 18, 2026 08:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the codebase to build against cuddle ≥ 1.8 by accommodating validateCBOR’s new Either-returning API, and bumps the lower bound on cuddle across packages/tests.

Changes:

  • Bump cuddle dependency lower bound from >=1.7 to >=1.8 in affected .cabal files.
  • Update CBOR validation call sites to handle Left parse errors returned by validateCBOR.
  • Refresh Nix flake lockfile for the Hackage snapshot input.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scls-util/src/Cardano/SCLS/Util/Verify.hs Handle validateCBOR parse failures and surface them as CBORParseError.
scls-cardano/test/Conformance.hs Treat validateCBOR parse failures as test failures with an error message.
scls-cardano/cddl-validate/Cardano/SCLS/CDDL/Validate.hs Adapt validateBytesAgainst to Either by dropping parse failures to Nothing.
scls-util/scls-util.cabal Bump cuddle lower bound to >=1.8.
scls-format/scls-format.cabal Bump cuddle lower bound to >=1.8 (test suite deps).
scls-core/scls-core.cabal Bump cuddle lower bound to >=1.8.
scls-cardano/scls-cardano.cabal Bump cuddle lower bound to >=1.8 across components.
flake.lock Update hackage.nix input revision/hash.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scls-cardano/cddl-validate/Cardano/SCLS/CDDL/Validate.hs
Comment thread scls-util/src/Cardano/SCLS/Util/Verify.hs
@joaosreis joaosreis mentioned this pull request May 18, 2026
@joaosreis joaosreis requested a review from qnikst May 18, 2026 08:35
@joaosreis joaosreis merged commit 8e2bba9 into main May 18, 2026
45 checks passed
@joaosreis joaosreis deleted the bump-cuddle-1.8.0.0 branch May 18, 2026 08:47
@joaosreis joaosreis restored the bump-cuddle-1.8.0.0 branch May 18, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants