Bump cuddle to 1.8.0.0#304
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the codebase to build against cuddle ≥ 1.8 by accommodating validateCBOR’s new Either-returning API, and bumps the lower bound on cuddle across packages/tests.
Changes:
- Bump
cuddledependency lower bound from>=1.7to>=1.8in affected.cabalfiles. - Update CBOR validation call sites to handle
Leftparse errors returned byvalidateCBOR. - Refresh Nix flake lockfile for the Hackage snapshot input.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scls-util/src/Cardano/SCLS/Util/Verify.hs | Handle validateCBOR parse failures and surface them as CBORParseError. |
| scls-cardano/test/Conformance.hs | Treat validateCBOR parse failures as test failures with an error message. |
| scls-cardano/cddl-validate/Cardano/SCLS/CDDL/Validate.hs | Adapt validateBytesAgainst to Either by dropping parse failures to Nothing. |
| scls-util/scls-util.cabal | Bump cuddle lower bound to >=1.8. |
| scls-format/scls-format.cabal | Bump cuddle lower bound to >=1.8 (test suite deps). |
| scls-core/scls-core.cabal | Bump cuddle lower bound to >=1.8. |
| scls-cardano/scls-cardano.cabal | Bump cuddle lower bound to >=1.8 across components. |
| flake.lock | Update hackage.nix input revision/hash. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
qnikst
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.