Skip to content

Add support for LeashID - #1

Merged
axman6 merged 4 commits into
add-leashing-0.22.4.0from
tweag/add-leashing-0.22.4.0-leashId
Feb 19, 2026
Merged

Add support for LeashID#1
axman6 merged 4 commits into
add-leashing-0.22.4.0from
tweag/add-leashing-0.22.4.0-leashId

Conversation

@axman6

@axman6 axman6 commented Feb 6, 2026

Copy link
Copy Markdown

(This is part of the plutus-script-reexecutor project's cardano-node leashing experimentation and not yet intended to be merged into master)

Description

reasonably detailed description of the pull request

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@tweag-ev-ak tweag-ev-ak left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

msgAcquire = [0, base.point, ? bool]
/ [8, ? bool]
/ [10, ? bool]
msgAcquire = [0, point, ? word32]

@adithyaov adithyaov Feb 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are choosing to modify msgAcquire as opposed to adding a new message. Is this what we want to do?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the time being, yeah, this change is backwards compatible, but adding the new error type isn't. Either way, this probably isn't the implementation we'll use going forwards anyway.

-> ClientStAcquiring block point query m a
-> ClientStIdle block point query m a

SendMsgDone :: a

@adithyaov adithyaov Feb 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also have a LeashId attached to it if we want to safely garbage collect the context associated with the client.

Update: To explicitly unleash

@axman6
axman6 force-pushed the tweag/add-leashing-0.22.4.0-leashId branch from 21d1fb2 to 0f03998 Compare February 11, 2026 01:02
@axman6
axman6 merged commit 63601d2 into add-leashing-0.22.4.0 Feb 19, 2026
2 of 6 checks passed
tweag-ev-ak pushed a commit that referenced this pull request Feb 19, 2026
* Changing leashing to use optional id

* Add LeashID for client identification

* Update tests and benchmarks

* Add optional LeashID to MsgRelease
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants