Trigger rollbacks on demand - #169
Merged
Merged
Conversation
9 tasks
adithyaov
force-pushed
the
rollback-rep-1
branch
from
March 27, 2026 06:01
d56d4c8 to
fe597a7
Compare
tweag-ev-ak
approved these changes
Mar 30, 2026
adithyaov
force-pushed
the
rollback-trigger
branch
2 times, most recently
from
March 31, 2026 18:37
c76003b to
f4c7766
Compare
Member
Author
|
Closes: #170 |
This was
linked to
issues
Mar 31, 2026
3 tasks
adithyaov
commented
Apr 1, 2026
adithyaov
force-pushed
the
rollback-trigger
branch
from
April 1, 2026 07:40
f4c7766 to
5793f7a
Compare
axman6
approved these changes
Apr 2, 2026
axman6
left a comment
axman6
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, there's probably some stuff that could be cleaned up but we should get it merged.
| [ shoveler appSock nodeSock ">" | ||
| , shoveler nodeSock appSock "<" | ||
| ] | ||
| pushLog "Disconnected. Reconnecting..." |
Contributor
There was a problem hiding this comment.
Is "Reconnecting" accurate? I think it just dies here?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.