Skip to content

Add bazel 8 compatibility #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

Add bazel 8 compatibility #2348

merged 1 commit into from
Oct 28, 2025

Conversation

@simeonwarren
Copy link
Contributor

@simeonwarren simeonwarren commented Oct 11, 2025 •
edited
Loading

This patch allows rules_haskell to work with my bazel 8 install (8.4.2)

Though they still need common --noincompatible_disallow_ctx_resolve_tools to function

@simeonwarren simeonwarren force-pushed the dev/fix_bazel_8_compat branch 3 times, most recently from 0f4b353 to 0fd7c9f Compare October 11, 2025 15:28
@simeonwarren simeonwarren marked this pull request as ready for review October 11, 2025 15:35
@simeonwarren simeonwarren requested a review from avdv as a code owner October 11, 2025 15:35
@simeonwarren simeonwarren mentioned this pull request Oct 17, 2025
Closed
avdv
avdv requested changes Oct 27, 2025
View reviewed changes
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Could you move the get_cpu_value.bzl file into haskell/private, please.

@avdv avdv linked an issue Oct 27, 2025 that may be closed by this pull request
Bazel 8 compatibility #2349
Closed
@simeonwarren simeonwarren force-pushed the dev/fix_bazel_8_compat branch from 0fd7c9f to c5f9029 Compare October 27, 2025 13:37
@simeonwarren
Copy link
Contributor Author

Thank you!

Could you move the get_cpu_value.bzl file into haskell/private, please.

Done

@simeonwarren simeonwarren requested a review from avdv October 27, 2025 13:40
avdv
avdv approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

The two CI jobs failing are because of #2346.

@avdv avdv merged commit a93b20a into tweag:master Oct 28, 2025
156 of 168 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avdv avdv avdv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bazel 8 compatibility

2 participants

@simeonwarren @avdv