Skip to content

update KeyValuePairType enum and add IS_CONFIG_VAR_IN_DB_ENABLED config var #11476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

ehconitin
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Warnings
⚠️ Changes were made to the config variables, but not to the documentation - Please review your changes and check if a change needs to be documented!

Generated by 🚫 dangerJS against e58ef31

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the KeyValuePairType enum across the codebase and introduces the new IS_CONFIG_VAR_IN_DB_ENABLED config variable.

  • Updated enum values and defaults in /packages/twenty-server/src/engine/core-modules/key-value-pair/key-value-pair.entity.ts to use standardized naming.
  • Added robust migration logic in /packages/twenty-server/src/database/typeorm/core/migrations/common/1743085000787-updateKeyValuePairTypeEnum.ts for safe value conversion.
  • Introduced IS_CONFIG_VAR_IN_DB_ENABLED in /packages/twenty-server/src/engine/core-modules/twenty-config/config-variables.ts with proper decorators.
  • Revised /packages/twenty-server/src/engine/core-modules/user/user-vars/services/user-vars.service.ts to reference the updated enum and updated .env.example accordingly.

5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparatory Changes 1 for DB-level Config
1 participant