Support Full Name as Record Text Identifier #11610

b9aurav · 2025-04-17T05:08:40Z

recording.webm

greptile-apps

PR Summary

This PR adds support for using full name fields as record text identifiers, allowing them to be clickable and selectable in the settings form.

Added FieldMetadataType.FULL_NAME to LABEL_IDENTIFIER_FIELD_METADATA_TYPES array in /packages/twenty-front/src/modules/object-metadata/constants/LabelIdentifierFieldMetadataTypes.ts
Removed 'fullName' from reserved keywords in /packages/twenty-server/src/engine/metadata-modules/utils/validate-metadata-name-is-not-reserved-keyword.ts
Enhanced RecordChip component in /packages/twenty-front/src/modules/object-record/components/RecordChip.tsx to handle full name concatenation
Modified ChipFieldDisplay and useChipFieldDisplay to properly handle full name fields as identifiers
Updated SettingsDataModelObjectIdentifiersForm to keep identifier fields clickable even with single field

_{💡 (5/5) You can turn off certain types of comments like style here!}

_{6 file(s) reviewed, 2 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-04-17T05:09:10Z

packages/twenty-front/src/modules/object-record/components/RecordChip.tsx

+  let name = recordChipData.name;
+
+  if (field?.type === FieldMetadataType.FULL_NAME) {
+    name = `${record[field.name]?.firstName || ''} ${record[field.name]?.lastName || ''}`;


style: Consider adding .trim() to remove extra space when either firstName or lastName is empty

Suggested change

name = `${record[field.name]?.firstName || ''} ${record[field.name]?.lastName || ''}`;

name = `${record[field.name]?.firstName || ''} ${record[field.name]?.lastName || ''}`.trim();

greptile-apps · 2025-04-17T05:09:25Z

...y-server/src/engine/metadata-modules/utils/validate-metadata-name-is-not-reserved-keyword.ts

  'currencies',
-  'fullName',
  'fullNames',


style: Consider whether 'fullNames' should also be removed for consistency since 'fullName' is now allowed

packages/twenty-front/src/modules/object-record/components/RecordChip.tsx

...y-server/src/engine/metadata-modules/utils/validate-metadata-name-is-not-reserved-keyword.ts

charlesBochet · 2025-04-17T09:11:47Z

...ules/settings/data-model/objects/forms/components/SettingsDataModelObjectIdentifiersForm.tsx

              fullWidth
              dropdownId={`${fieldName}-select`}
              emptyOption={emptyOption}
              options={options}
              value={value}
+              withSearchInput={label === t`Record label`}


I don't understand this change

In Issue, required change is only in 'Record Label' dropdown, Not in 'Record Image' dropdown.

...ules/settings/data-model/objects/forms/components/SettingsDataModelObjectIdentifiersForm.tsx

charlesBochet · 2025-04-17T09:12:07Z

...nt/src/modules/object-record/record-field/meta-types/display/components/ChipFieldDisplay.tsx

@@ -22,6 +23,10 @@ export const ChipFieldDisplay = () => {
      size={ChipSize.Small}
      to={labelIdentifierLink}
      isLabelHidden={isLabelIdentifierCompact}
+      field={{


see comment above

charlesBochet

Hi @b9aurav, thanks for the PR
I have left comments :)

b9aurav · 2025-04-17T11:47:01Z

@charlesBochet Thanks for your comments, I'll take a look at requested changes.

…nd remove unused field prop

charlesBochet · 2025-05-12T12:49:09Z

packages/twenty-front/src/modules/object-metadata/utils/getLabelIdentifierFieldValue.ts

@@ -13,7 +13,7 @@ export const getLabelIdentifierFieldValue = (
    objectNameSingular === CoreObjectNameSingular.WorkspaceMember ||
    labelIdentifierFieldMetadataItem?.type === FieldMetadataType.FULL_NAME
  ) {
-    return `${record.name?.firstName ?? ''} ${record.name?.lastName ?? ''}`;
+    return `${record[labelIdentifierFieldMetadataItem?.name ?? '']?.firstName ?? ''} ${record[labelIdentifierFieldMetadataItem?.name ?? '']?.lastName ?? ''}`;


we should throw if we can't find the labelIdentifierFieldMetadataItem

charlesBochet · 2025-05-12T12:50:32Z

packages/twenty-front/src/modules/object-record/hooks/useRecordChipData.ts

@@ -20,19 +22,26 @@ export const useRecordChipData = ({
    PreComputedChipGeneratorsContext,
  );

+  const { fieldDefinition } = useContext(FieldContext);
+  const updatedRecord = { ...record };


let's avoid creating a fake record having a "name", this will create confusion in the code. Instead, we can passe to identifierChipGenerator and generateDefaultRecordChipData what we need

charlesBochet · 2025-05-19T22:02:56Z

Thank you @b9aurav, I've made some small modifications to remove previous technical debt

github-actions · 2025-05-19T22:03:22Z

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:31034

This environment will automatically shut down when the PR is closed or after 5 hours.

github-actions · 2025-05-19T22:04:30Z

Thanks @b9aurav for your contribution!
This marks your 10th PR on the repo. You're top 4% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Support Full Name as Record Text Identifier

18382c7

greptile-apps bot reviewed Apr 17, 2025

View reviewed changes