refactor(config): rename ANALYTICS_ENABLED to IS_ANALYTICS_ENABLED
#11652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces changes to standardize environment variable naming while also making significant security and database configuration changes.
- CRITICAL: Disabling TLS certificate validation in
packages/twenty-front/codegen.cjsandcodegen-metadata.cjswithNODE_TLS_REJECT_UNAUTHORIZED = '0'creates serious security vulnerabilities - Added
allow_experimental_json_typeandindex_granularity=8192settings to ClickHouse tables inpackages/twenty-server/src/database/clickhouse/migrations/001-create-events-table.sqland002-create-pageview-table.sql - Renamed
ANALYTICS_ENABLEDtoIS_ANALYTICS_ENABLEDacross multiple files for consistent boolean naming convention - Potential issue in
analytics.service.tswhereAnalyticsExceptionis returned instead of thrown inpreventAnalyticsIfDisabledmethod
18 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-server/src/database/clickhouse/migrations/002-create-pageview-table.sql
Show resolved
Hide resolved
packages/twenty-server/src/database/clickhouse/migrations/run-migrations.ts
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Updated all occurrences of `ANALYTICS_ENABLED` to `IS_ANALYTICS_ENABLED` for better naming consistency. Adjusted environment variables, code references, and tests accordingly to reflect the change. line setting NODE_TLS_REJECT_UNAUTHORIZED to '0'. This improves security by no longer bypassing TLS certificate validation.
AMoreaux
force-pushed
the
fix/adapte-migration-to-clickhouse-cloud
branch
from
4db6829 to
8c76260
Compare
Added a new script command to run ClickHouse migrations in production. This ensures proper database setup for ClickHouse during deployment.
Removed the command to enable the experimental JSON type as it is no longer required. This simplifies the migration script and aligns with updated database configuration practices.
Cleaned up unnecessary ESLint disable comments and outdated TODO notes across various components. This improves code readability and reduces clutter without affecting functionality.
| @@ -29,7 +29,7 @@ export const GET_CLIENT_CONFIG = gql` | |||
| defaultSubdomain | |||
| frontDomain | |||
| debugMode | |||
| analyticsEnabled | |||
| isAnalyticsEnabled | |||
There was a problem hiding this comment.
Maybe let's rename the env variable only since this will create a breaking change during the next deploy :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all occurrences of
ANALYTICS_ENABLEDtoIS_ANALYTICS_ENABLEDfor better naming consistency. Adjusted environment variables, code references, and tests accordingly to reflect the change.