Skip to content

Fix form record picker field #11817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 5, 2025
Merged

Fix form record picker field #11817

merged 7 commits into from
May 5, 2025

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Apr 30, 2025

  • enrich response so the record is available in the step output. Today this is available in the schema but only the id is set
  • make the full record picker clickable instead of the arrow only
Capture d’écran 2025-04-30 à 16 08 04

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances form record picker functionality by making the entire picker clickable and enriching workflow step outputs with complete record data instead of just IDs.

  • Added enrichFormStepResponse method in workflow-version-step.workspace-service.ts to fetch full record data for form submissions
  • Updated FormSingleRecordPicker styling with hover states and cursor pointer, changing dropdown placement to 'bottom-start'
  • Modified Dropdown component to support configurable widths via new clickableComponentWidth prop
  • Added proper event propagation handling in FormSingleRecordFieldChip for remove actions
  • Added 'INVALID' exception code to handle form validation errors

5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

github-actions bot commented Apr 30, 2025

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:51845

This environment will automatically shut down when the PR is closed or after 5 hours.

@thomtrp thomtrp force-pushed the tt-fix-form-select-record branch from 65a0f1c to 3927495 Compare April 30, 2025 15:21
Copy link
Contributor

@Devessier Devessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! The forms will look better after we merge it.
Let's discuss a few elements before merging.

@Devessier Devessier self-requested a review May 5, 2025 09:16
@Devessier
Copy link
Contributor

What do you think about this behavior, @thomtrp?

CleanShot.2025-05-05.at.11.29.25.mp4

@Devessier
Copy link
Contributor

An Update Record action selects the first record in database if the resolved variable is undefined

CleanShot.2025-05-05.at.11.38.17.mp4

Copy link
Contributor

@Devessier Devessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Let's confirm the two behaviors I mentioned in previous comments before merging.

@thomtrp thomtrp enabled auto-merge (squash) May 5, 2025 12:49
@thomtrp thomtrp merged commit 6128d66 into main May 5, 2025
52 checks passed
@thomtrp thomtrp deleted the tt-fix-form-select-record branch May 5, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants