-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix form record picker field #11817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix form record picker field #11817
Conversation
thomtrp
commented
Apr 30, 2025
- enrich response so the record is available in the step output. Today this is available in the schema but only the id is set
- make the full record picker clickable instead of the arrow only

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR enhances form record picker functionality by making the entire picker clickable and enriching workflow step outputs with complete record data instead of just IDs.
- Added
enrichFormStepResponse
method inworkflow-version-step.workspace-service.ts
to fetch full record data for form submissions - Updated
FormSingleRecordPicker
styling with hover states and cursor pointer, changing dropdown placement to 'bottom-start' - Modified
Dropdown
component to support configurable widths via newclickableComponentWidth
prop - Added proper event propagation handling in
FormSingleRecordFieldChip
for remove actions - Added 'INVALID' exception code to handle form validation errors
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...c/modules/workflow/workflow-builder/workflow-step/workflow-version-step.workspace-service.ts
Outdated
Show resolved
Hide resolved
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:51845 This environment will automatically shut down when the PR is closed or after 5 hours. |
65a0f1c
to
3927495
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! The forms will look better after we merge it.
Let's discuss a few elements before merging.
...ront/src/modules/object-record/record-field/form-types/components/FormSingleRecordPicker.tsx
Show resolved
Hide resolved
...ront/src/modules/object-record/record-field/form-types/components/FormSingleRecordPicker.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/dropdown/components/Dropdown.tsx
Show resolved
Hide resolved
...c/modules/workflow/workflow-builder/workflow-step/workflow-version-step.workspace-service.ts
Show resolved
Hide resolved
What do you think about this behavior, @thomtrp? CleanShot.2025-05-05.at.11.29.25.mp4 |
An Update Record action selects the first record in database if the resolved variable is undefined CleanShot.2025-05-05.at.11.38.17.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Let's confirm the two behaviors I mentioned in previous comments before merging.