Fix form record picker field #11817
Fix form record picker field #11817
Conversation
thomtrp
commented
Apr 30, 2025
thomtrp
commented
- enrich response so the record is available in the step output. Today this is available in the schema but only the id is set
- make the full record picker clickable instead of the arrow only
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances form record picker functionality by making the entire picker clickable and enriching workflow step outputs with complete record data instead of just IDs.
- Added
enrichFormStepResponsemethod inworkflow-version-step.workspace-service.tsto fetch full record data for form submissions - Updated
FormSingleRecordPickerstyling with hover states and cursor pointer, changing dropdown placement to 'bottom-start' - Modified
Dropdowncomponent to support configurable widths via newclickableComponentWidthprop - Added proper event propagation handling in
FormSingleRecordFieldChipfor remove actions - Added 'INVALID' exception code to handle form validation errors
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...c/modules/workflow/workflow-builder/workflow-step/workflow-version-step.workspace-service.ts
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:21639 This environment will automatically shut down when the PR is closed or after 5 hours. |
thomtrp
force-pushed
the
tt-fix-form-select-record
branch
from
65a0f1c to
3927495
Compare
| closeDropdown(); | ||
|
|
||
| const handleUnlinkVariable = (event?: React.MouseEvent<HTMLDivElement>) => { | ||
| event?.stopPropagation(); |
There was a problem hiding this comment.
For anyone reading this PR, the stopPropagation prevents the dropdown to open when clicking on the "Delete" icon of a VariableChipStandalone. See the video below.
CleanShot.2025-04-30.at.18.02.35.mp4
There was a problem hiding this comment.
I feel there might be a less "hacky" solution to this. We might ask Lucas.
There was a problem hiding this comment.
Let's create stories for this component. We did a great job writing stories for most of the Form components, and this component shouldn't be an exception.
| `; | ||
|
|
||
| export type DropdownProps = { | ||
| className?: string; | ||
| clickableComponent?: ReactNode; | ||
| clickableComponentWidth?: Width; |
There was a problem hiding this comment.
I know you took the time to find the best solution to this problem, but I wonder if we didn't find an API design flaw in the Dropdown component. We can provide a clickableComponent, but won't the width of the clickable area expand to the bounds of the clickableComponent? This looks strange to me, and maybe we should discuss it.
| ); | ||
|
|
||
| const record = await repository.findOne({ | ||
| where: { id: response[key].id }, |
There was a problem hiding this comment.
As discussed in private, an error is thrown here after having clicked on the option "No notes" because we send a string that's not a UUID and that throws here.
