Skip to content

Conversation

@guillim
Copy link
Contributor

@guillim guillim commented Apr 30, 2025

After reading the blocknote documentation :

  • we decided to increase to 100% the lines width
  • we decided to reduce as much as possible inner padding
  • we decided it's on the parent to decide the padding of the richtext
    The two last points are recommended in a discussion on the project blocknote. This way clicking on padding won't trigger weird behaviour on Chrome.

Fixes twentyhq/core-team-issues#827 (comment)

@guillim guillim self-assigned this Apr 30, 2025
@github-actions
Copy link
Contributor

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:28060

This environment will automatically shut down when the PR is closed or after 5 hours.

@guillim guillim marked this pull request as ready for review May 5, 2025 12:49
@guillim guillim enabled auto-merge (squash) May 5, 2025 12:49
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR implements styling adjustments for the BlockNote editor integration, focusing on padding control and width management to prevent Chrome-specific click behavior issues.

  • Removed inner padding (44px) from BlockEditor.tsx and delegated padding control to parent components
  • Added box-sizing: border-box to containers in ShowPageActivityContainer.tsx and CommandMenuEditRichTextPage.tsx for consistent sizing
  • Set width: 100% in BlockEditor.tsx inline content for full-width lines
  • Adjusted RichTextFieldInput.tsx container with left padding (theme.spacing(12)) and negative margin adjustments
  • Modified container positioning in affected components to ensure proper Chrome click behavior

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@guillim guillim requested a review from etiennejouan May 5, 2025 12:51
Copy link
Contributor

@etiennejouan etiennejouan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏 👏
(seen together position:relative to remove)

@guillim guillim merged commit da0c7e6 into main May 5, 2025
54 of 57 checks passed
@guillim guillim deleted the blocknote-editor-fix branch May 5, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

when editing a note, we cannot put the cursor at the end of the line

4 participants