Skip to content

Conversation

BOHEUS
Copy link
Contributor

@BOHEUS BOHEUS commented Oct 8, 2025

Fixes #14888

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR addresses a dark theme color issue in the workflow steps UI by adding proper theme-aware coloring to the 'No body' message displayed when HTTP request workflow steps have no body content. The change adds a single line to the `StyledNoBodyMessage` styled component, setting the color to `theme.font.color.light`, which ensures the text displays with appropriate contrast in both light and dark themes.

The fix is part of the workflow module's HTTP request action components and follows the existing theming patterns used throughout the codebase. This change specifically targets the issue where empty workflow node text was appearing black instead of following the active theme colors, creating poor visibility in dark mode.

Changed Files
Filename Score Overview
packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/BodyInput.tsx 5/5 Added theme-aware color property to StyledNoBodyMessage component for proper dark theme support

Confidence score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects a simple, targeted theme fix that follows established patterns in the codebase
  • No files require special attention

Sequence Diagram

sequenceDiagram
    participant User
    participant WorkflowStepBody
    participant BodyInput
    participant Select
    participant FormComponents
    participant Theme

    User->>WorkflowStepBody: "Views workflow step with no data"
    WorkflowStepBody->>Theme: "Applies theme.font.color.light"
    WorkflowStepBody-->>User: "Displays with light text color"
    
    User->>BodyInput: "Interacts with HTTP request body input"
    BodyInput->>Select: "Renders body type dropdown"
    Select-->>BodyInput: "Returns selected body type"
    
    alt Body type is "None"
        BodyInput->>BodyInput: "Renders StyledNoBodyMessage"
        BodyInput->>Theme: "Applies theme.font.color.light"
        BodyInput-->>User: "Shows 'No body' message with light color"
    else Body type is "Raw JSON"
        BodyInput->>FormComponents: "Renders FormRawJsonFieldInput"
        FormComponents-->>User: "Shows JSON input field"
    else Body type is "Key/Value" or "Form Data"
        BodyInput->>FormComponents: "Renders KeyValuePairInput"
        FormComponents-->>User: "Shows key-value input fields"
    else Body type is "Text"
        BodyInput->>FormComponents: "Renders FormTextFieldInput"
        FormComponents-->>User: "Shows text input field"
    end
    
    User->>BodyInput: "Changes body type selection"
    BodyInput->>BodyInput: "Calls handleModeChange"
    BodyInput->>BodyInput: "Updates headers and resets state"
    BodyInput-->>User: "Updates UI with new input type"
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

github-actions bot commented Oct 8, 2025

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:23692

This environment will automatically shut down when the PR is closed or after 5 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text in empty node is black instead of contrasting to selected theme

1 participant