Fix 2.16 search field metadata cross version upgrade

[prastoin]

Introduction

Allow decorating at class scope the properties introduced in specific upgrade command

@WasIntroducedInUpgrade({
  upgradeCommandName:
    ADD_UNIVERSAL_IDENTIFIER_AND_APPLICATION_ID_TO_SEARCH_FIELD_METADATA_UPGRADE_COMMAND_NAME,
  properties: ['universalIdentifier', 'applicationId', 'position'],
})

Here the search field metadata has been created as it without extending the syncableEntity a previous PR I've created now extends it, but nothing has been protected the fact they're not decorated. Also having to re-declare the properties would be redundant to me

[twenty-ci-bot-public]

🔍 Automated Pre-Review

✅ No issues detected - This PR is ready for human review.

---

View details

Automated pre-review — human approval still required.

[cubic-dev-ai]

1 issue found across 9 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/twenty-server/src/engine/twenty-orm/upgrade-aware/upgrade-aware-entity-metadata.adapter.ts">

<violation number="1" location="packages/twenty-server/src/engine/twenty-orm/upgrade-aware/upgrade-aware-entity-metadata.adapter.ts:365">
P2: Validation now accepts relation property names for `@WasIntroducedInUpgrade(properties)`, but upgrade-aware resolution only supports columns. This can hide misconfigured decorators that never take effect.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[Weiko]

LGTM

[Weiko]

FYI TS applies class decorators after property decorators