fix(client-sdk): regenerate metadata client after isCustomDomainEnabled schema change#22043
Closed
FelixMalfait wants to merge 1 commit into
Closed
fix(client-sdk): regenerate metadata client after isCustomDomainEnabled schema change#22043FelixMalfait wants to merge 1 commit into
FelixMalfait wants to merge 1 commit into
Conversation
PR #22037 added the nullable isCustomDomainEnabled field to the DomainValidRecords GraphQL type but did not regenerate twenty-client-sdk, breaking the SDK metadata client up-to-date check on main. Regenerate src/metadata/generated to include the new field. Output verified byte-identical to twenty-client-sdk:generate-metadata-client. Claude-Session: https://claude.ai/code/session_01BB6C6bpPZMUbMzKSCydEaj
prastoin
reviewed
Jun 23, 2026
Member
There was a problem hiding this comment.
Hey there, unless i'm mistaken duplicated of already merged https://github.com/twentyhq/twenty/pull/22042/changes
Weird that it still finds a diff to create a PR from
Member
Author
|
Thanks @prastoin — you're right, #22042 already landed the exact same regeneration. Closing this as a duplicate. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#22037 added the nullable
isCustomDomainEnabledfield to theDomainValidRecordsGraphQL type but did not regeneratetwenty-client-sdk. This breaks the SDK metadata client up-to-date check on main (ci-server.yamlrunsnpx nx run twenty-client-sdk:generate-metadata-clientand fails ifgit diffonpackages/twenty-client-sdk/src/metadata/generatedis non-empty), as flagged by @prastoin here.Fix
Regenerate
packages/twenty-client-sdk/src/metadata/generatedto include the new field:schema.graphql:isCustomDomainEnabled: BooleanonDomainValidRecordsschema.ts: the field on theDomainValidRecordsinterface and itsGenqlSelectiontypes.ts: the field in the runtime type descriptorVerification
Since there's no live backend in this environment, I ran the actual genql generator (
twenty-client-sdk's vendoredgenerate) against the updated/metadataSDL into a scratch dir and confirmed the output is byte-identical to the committed files (diffreports no differences forschema.graphql,schema.ts,types.ts;index.tsandruntime/are unaffected — the field addition doesn't touch them). Sogenerate-metadata-client+git diffwill be clean in CI.I also re-ran the front metadata codegen offline against the same SDL to double-check #22037's hand-edited
twenty-front/src/generated-metadata/graphql.ts: zero diffs in theDomainValidRecords/CheckCustomDomainregions, confirming that file is already correct and only the SDK was stale.https://claude.ai/code/session_01BB6C6bpPZMUbMzKSCydEaj
Generated by Claude Code