Skip to content

fix(client-sdk): regenerate metadata client after isCustomDomainEnabled schema change#22043

Closed
FelixMalfait wants to merge 1 commit into
mainfrom
claude/fix-client-sdk-custom-domain
Closed

fix(client-sdk): regenerate metadata client after isCustomDomainEnabled schema change#22043
FelixMalfait wants to merge 1 commit into
mainfrom
claude/fix-client-sdk-custom-domain

Conversation

@FelixMalfait

@FelixMalfait FelixMalfait commented Jun 23, 2026

Copy link
Copy Markdown
Member

Problem

#22037 added the nullable isCustomDomainEnabled field to the DomainValidRecords GraphQL type but did not regenerate twenty-client-sdk. This breaks the SDK metadata client up-to-date check on main (ci-server.yaml runs npx nx run twenty-client-sdk:generate-metadata-client and fails if git diff on packages/twenty-client-sdk/src/metadata/generated is non-empty), as flagged by @prastoin here.

Fix

Regenerate packages/twenty-client-sdk/src/metadata/generated to include the new field:

  • schema.graphql: isCustomDomainEnabled: Boolean on DomainValidRecords
  • schema.ts: the field on the DomainValidRecords interface and its GenqlSelection
  • types.ts: the field in the runtime type descriptor

Verification

Since there's no live backend in this environment, I ran the actual genql generator (twenty-client-sdk's vendored generate) against the updated /metadata SDL into a scratch dir and confirmed the output is byte-identical to the committed files (diff reports no differences for schema.graphql, schema.ts, types.ts; index.ts and runtime/ are unaffected — the field addition doesn't touch them). So generate-metadata-client + git diff will be clean in CI.

I also re-ran the front metadata codegen offline against the same SDL to double-check #22037's hand-edited twenty-front/src/generated-metadata/graphql.ts: zero diffs in the DomainValidRecords / CheckCustomDomain regions, confirming that file is already correct and only the SDK was stale.

https://claude.ai/code/session_01BB6C6bpPZMUbMzKSCydEaj


Generated by Claude Code

Review in cubic

PR #22037 added the nullable isCustomDomainEnabled field to the
DomainValidRecords GraphQL type but did not regenerate twenty-client-sdk,
breaking the SDK metadata client up-to-date check on main.

Regenerate src/metadata/generated to include the new field. Output verified
byte-identical to twenty-client-sdk:generate-metadata-client.

Claude-Session: https://claude.ai/code/session_01BB6C6bpPZMUbMzKSCydEaj

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

@prastoin prastoin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, unless i'm mistaken duplicated of already merged https://github.com/twentyhq/twenty/pull/22042/changes
Weird that it still finds a diff to create a PR from

Copy link
Copy Markdown
Member Author

Thanks @prastoin — you're right, #22042 already landed the exact same regeneration. Closing this as a duplicate.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants