Skip to content

Conversation

@dennistobar
Copy link
Contributor

This PR implement a new Inflector using Spanish (ISO Code = es) implemented in this PR symfony/symfony#58228.

  • I sort the list of supported Inflectors to follow some rule (alphabet?)
  • I just change invalid test from "it" to "qq" (qq doesn't exist as valid ISO code, but it is italian... don't be evil if anyone want to create the italian inflector 😅 )

@fabpot fabpot force-pushed the spanish-inflector branch from 2ec7121 to 290a923 Compare November 3, 2024 14:08
@fabpot
Copy link
Contributor

fabpot commented Nov 3, 2024

Thank you @dennistobar.

@fabpot fabpot merged commit 8d3bad4 into twigphp:3.x Nov 3, 2024
fabpot added a commit that referenced this pull request Nov 20, 2024
…y/string (stof)

This PR was merged into the 3.x branch.

Discussion
----------

Fix the string-extra tests when running with older symfony/string

My review comment in #4426 (comment) was not taken into account to handle the case of using a version of `symfony/string` without the SpanishInflector, and the PR was merged with broken tests.

Commits
-------

abc34bd Fix the string-extra tests when running with older symfony/string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants