Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default value for html_input, quote the unordered_list_markers va… #14

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

tacman
Copy link

@tacman tacman commented Feb 8, 2025

configuration fix, so that

bin/console config:dump twig_extra > config/packages/twig_extra.yaml

now generated valid yaml and a valid configuration.

But I'm not sure that quoting the default values is correct.

                                ->defaultValue(["'-'", "'*'", "'+'"])

The YAML dumper should probably check for yaml keywords like these and quote them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant