Skip to content

fix(standby)!: make rustc infer the predicate type #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vilgotf wants to merge 8 commits into
base: next
Choose a base branch
from
Open

fix(standby)!: make rustc infer the predicate type #2499

vilgotf wants to merge 8 commits into from

Conversation

@vilgotf
Copy link
Member

@vilgotf vilgotf commented Dec 29, 2025 •
edited
Loading

Removes the generic impl Into<Box<F>> so that rustc can infer the predicate type. Other changes include:

  • Removing the tracing dependency: its usefulness is questionable
  • Correct component predicate to take &InteractionCreate instead of &Interaction
  • Shrink the futures' code size: box the check predicate prior to calling non-generic code
  • Make the futures generic over their type

@github-actions github-actions bot added c-book Affects the book c-standby Affects the standby crate m-breaking change Breaks the public API. t-refactor Refactors APIs or code. labels Dec 29, 2025
@vilgotf vilgotf changed the title refactor(standby)!: restructure internals fix(standby)!: make rustc infer the predicate type Dec 29, 2025
@github-actions github-actions bot added the t-fix Fixes a bug in the library label Dec 29, 2025
@vilgotf vilgotf removed the t-refactor Refactors APIs or code. label Dec 29, 2025
Erk-
Erk- requested changes Dec 29, 2025
View reviewed changes
Copy link
Member

@Erk- Erk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only one small nit about some complexity that I don't think is needed.

@vilgotf vilgotf requested a review from Erk- December 30, 2025 08:04
@vilgotf vilgotf mentioned this pull request Dec 30, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HTGAzureX1212 HTGAzureX1212 HTGAzureX1212 approved these changes

@Erk- Erk- Awaiting requested review from Erk-

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

c-book Affects the book c-standby Affects the standby crate m-breaking change Breaks the public API. t-fix Fixes a bug in the library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vilgotf @Erk- @HTGAzureX1212