Feature: Added site to Plugin options - #8
Open
ricardomarsanc wants to merge 3 commits into
Open
Conversation
site to Plugin configuration variablessite to Plugin options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
After trying to use this plugin to integrate Datadog into my Docusaurus site, I run into a permission issue due to my Datadog instance to be in Europe instead of the States. That means I have to send the proper
sitevariable, which is "datadoghq.eu" for Europe instances, instead of "datadoghq.com".This PR aims to allow the
sitevariable to be sent as another option for the plugin, allowing users to configure the integration properly regardless of where their Datadog instance is based.Changes
sitetoPluginOptions(string)sitevariable when initializing Datadog instead of the default "datadoghq.com"sitevariable is being received correctly when sent.Contributing to Twilio