Skip to content

Feature: Added site to Plugin options - #8

Open
ricardomarsanc wants to merge 3 commits into
twilio-labs:mainfrom
ricardomarsanc:feat/add-site-variable
Open

Feature: Added site to Plugin options#8
ricardomarsanc wants to merge 3 commits into
twilio-labs:mainfrom
ricardomarsanc:feat/add-site-variable

Conversation

@ricardomarsanc

@ricardomarsanc ricardomarsanc commented Apr 2, 2024

Copy link
Copy Markdown

Context

After trying to use this plugin to integrate Datadog into my Docusaurus site, I run into a permission issue due to my Datadog instance to be in Europe instead of the States. That means I have to send the proper site variable, which is "datadoghq.eu" for Europe instances, instead of "datadoghq.com".

This PR aims to allow the site variable to be sent as another option for the plugin, allowing users to configure the integration properly regardless of where their Datadog instance is based.

Changes

  • Added site to PluginOptions (string)
  • Send the site variable when initializing Datadog instead of the default "datadoghq.com"
  • Added a new test to check that the site variable is being received correctly when sent.
  • Added another extra test to check that when no optional options are sent, the result has the correct default values 👍🏽

The new site variable falls back to "datadoghq.com", so no need to pass it in case you don't need a specific one. This makes this change non-breaking in case existing users upgrade to newer versions.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@ricardomarsanc ricardomarsanc changed the title Feature: Added site to Plugin configuration variables Feature: Added site to Plugin options Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant