Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove halo when blurring #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove halo when blurring #103

wants to merge 1 commit into from

Conversation

jpodwys
Copy link

@jpodwys jpodwys commented Feb 23, 2025

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

This PR removes the halo around humans when using background blur. I accomplish this by removing humans from the background prior to applying blur. After applying blur, I re-add any humans to the image.

Please let me know if you'd like any additional changes made. Thank you!

Before and After

Before
Screenshot 2025-02-23 at 10 56 08 AM

After
Screenshot 2025-02-23 at 10 56 29 AM

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

@charliesantos
Copy link
Collaborator

This is great @jpodwys ! Thanks for submitting. We will need to to run some tests on low powered devices and see if there's any impact on performance. Let's keep this open for now.

@jpodwys
Copy link
Author

jpodwys commented Feb 24, 2025

That sounds great, thanks!

@jpodwys
Copy link
Author

jpodwys commented Mar 10, 2025

Good morning @charliesantos, I wanted to check the status on this PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants