-
Notifications
You must be signed in to change notification settings - Fork 22
Simplify Server registration v2 #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sagikazarmark
merged 7 commits into
twirphp:master
from
cybercog:add-server-with-path-prefix-interface
Nov 26, 2025
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ba54759
Add a new way to register servers
antonkomarev bfe8e75
Fix PHPStan
antonkomarev 4549706
Fix PHPStan
antonkomarev e8562f2
Fix PHPStan
antonkomarev 996667d
Remove PHP7.4 and PHP8.0 support
antonkomarev 236439f
Add a new way to register servers
antonkomarev 52e8def
Add a new way to register servers
antonkomarev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Twirp; | ||
|
|
||
| interface ServerWithPathPrefix | ||
| { | ||
| /** | ||
| * Returns the base service path, in the form: "/<prefix>/<package>.<Service>/" | ||
| * that is everything in a Twirp route except for the <Method>. This can be used for routing, | ||
| * for example, to identify the requests that are targeted to this service in a mux. | ||
| */ | ||
| public function getPathPrefix(): string; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have intersection types here, but they are supported since php8.1, and this will require to drop php7.4 & php8.0 support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option that ServerWithPathPrefix should extend RequestHandlerInterface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given 8.0 has been EOL for almost two years now, I don't think dropping support would be a huge issue.
I'm not against extending the request handler interface either, just make sure it's implemented by the generated servers separately as well (to follow the concept we agreed to in the other PR)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagikazarmark I suggest to move forward and drop old PHP versions support. It will help us to use all features of the language.
In a 4 days PHP8.5 will be released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagikazarmark and I propose to remove deprecated
\Twirp\Serverclass, since it's deprecated for a 4 years already.