Fix raiser extension to be installed in the package#19
Merged
Conversation
Fix the build system to build the `raiser` extension inside the `cython_test_exception_raiser` package rather than as a top-level extension. This reduces site-packages pollution, and restores compatibility with 1.x releases. Fixes twisted/twisted#12608 Signed-off-by: Michał Górny <mgorny@gentoo.org>
adiroiban
approved these changes
Apr 5, 2026
adiroiban
left a comment
adiroiban
left a comment
Member
There was a problem hiding this comment.
Thanks. Looks good.
I added a suggestion for the release notes so that they read less like a commit message and more like a release note.
If you are happy with the suggestion we can merge and look into doing a new release.
Thanks again
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
Contributor
Author
|
LGTM. Thanks! |
Member
|
Thanks. Let's see if I remeber how to do new release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the build system to build the
raiserextension inside thecython_test_exception_raiserpackage rather than as a top-level extension. This reduces site-packages pollution, and restores compatibility with 1.x releases.Fixes twisted/twisted#12608