Add a test to avoid regression in the alias handling#588
Open
tristanlatr wants to merge 6 commits intomasterfrom
Open
Add a test to avoid regression in the alias handling#588tristanlatr wants to merge 6 commits intomasterfrom
tristanlatr wants to merge 6 commits intomasterfrom
Conversation
Codecov ReportBase: 92.31% // Head: 92.31% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 45 45
Lines 7959 7959
Branches 1736 1736
=======================================
Hits 7347 7347
Misses 356 356
Partials 256 256 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tristanlatr
commented
May 23, 2022
Contributor
Author
|
Closing this in favour of #589 which includes this test. |
Contributor
Author
|
Since this PR only adds a new test, I'll merge it as soon as the status is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only adds a new test.
We can see that for Attributes, first analyzed assignent wins. But for the Classes, it's something else