Skip to content

Improve search bar UX#934

Open
tristanlatr wants to merge 22 commits intomasterfrom
822-search-improvements
Open

Improve search bar UX#934
tristanlatr wants to merge 22 commits intomasterfrom
822-search-improvements

Conversation

@tristanlatr
Copy link
Contributor

@tristanlatr tristanlatr commented Nov 8, 2025

Search UX part 1: Result selection and shortcuts.

Search UX part 2: If the search box contains "docstring:" enable search in docstrings automatically.

Search UX part 3: Use a logical "and" in between search terms by default. Use leading '?' to make a term optional.

Add the « kind » field to the default index.

Do not give a boost to container type objects in the search index.

Show "Loading..." when the index file is not in memory yet

TODOs:

  • Only load first 50 results by default and insert a button to load the entire list
  • Do not store the "kind" field in the index at all, instead make it a "post-process field" that is applied after the query runs. That's probably not a good idea
  • If a search yields no PUBLIC results at all, then display the private results automatically
  • If a search yields no results AT ALL, then leverage the fuzzy search feature of lunrjs and re-launch the query with ~1
  • Move/duplicate the "Show private" button inside the search box so easily accessible
  • Load the query string from the URL parameter ?search=term
  • If the search is launch from a submodule/one of the root modules of the system, propose to search only in the current module.

Fixes #822

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.38%. Comparing base (87ffe4c) to head (d1576fb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
- Coverage   93.38%   93.38%   -0.01%     
==========================================
  Files          48       48              
  Lines        8954     8949       -5     
  Branches     1640     1639       -1     
==========================================
- Hits         8362     8357       -5     
  Misses        336      336              
  Partials      256      256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

This comment has been minimized.

7 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@tristanlatr tristanlatr force-pushed the 822-search-improvements branch from c18a1b3 to f95fd2b Compare November 8, 2025 22:16
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@tristanlatr tristanlatr force-pushed the 822-search-improvements branch from e50057d to 1d687bc Compare November 8, 2025 22:59
@github-actions

This comment has been minimized.

3 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@tristanlatr tristanlatr force-pushed the 822-search-improvements branch 2 times, most recently from 7612013 to f055424 Compare November 9, 2025 00:18
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

@github-actions
Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

@github-actions
Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

@github-actions
Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

@github-actions
Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

@github-actions
Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

@github-actions
Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

@github-actions
Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

@github-actions
Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

@github-actions
Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

@github-actions
Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ideas for search bar improvments

1 participant