Merge main into branch.#33
Conversation
twitchax
merged commit 43cf1a3
into
copilot/add-mode-and-scale-support
There was a problem hiding this comment.
Pull request overview
This PR merges main into the branch, primarily introducing formatting changes from a new leptosfmt tool integration. The changes include multi-line formatting of Leptos view macros, build tooling improvements with cargo-binstall integration, and a new GitHub workflow for Copilot setup.
Changes:
- Reformatted Leptos view macros across all web components for better readability (multi-line attributes, consistent spacing)
- Added
leptosfmtintegration to Makefile.toml with new formatting tasks - Updated documentation to recommend
cargo-binstallfor faster tool installation - Added new GitHub workflow file for Copilot setup steps
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| kord-web/tests/web.rs | Formatting: self-closing tag spacing |
| kord-web/src/client/shared/mod.rs | Multi-line formatting of view macros, improved readability |
| kord-web/src/app/mod.rs | Multi-line formatting of HTML attributes and view components |
| kord-web/src/app/listen.rs | Reformatted view macro with proper indentation |
| kord-web/src/app/home.rs | Split long text attributes into multiple lines |
| kord-web/src/app/guess.rs | Improved formatting of nested view components |
| kord-web/src/app/docs.rs | Multi-line formatting of code examples and links |
| kord-web/src/app/describe.rs | Reformatted fallback views |
| Makefile.toml | Added leptosfmt tasks, changed install_crate to dependencies |
| DEVELOPMENT.md | Updated tool installation instructions with cargo-binstall |
| AGENTS.md | Added cargo-binstall recommendations |
| .github/workflows/copilot-setup-steps.yml | New workflow file for Copilot CI setup |
| .github/copilot-instructions.md | Added tool installation guidance |
| <div class="kord-chord-analysis__detail"><span class="kord-chord-analysis__label">Scale: </span>{scale}</div> | ||
| <div class="kord-chord-analysis__detail"><span class="kord-chord-analysis__label">Chord: </span>{chord_tones}</div> | ||
| <div class="kord-chord-analysis__detail"> | ||
| <span class="kord-chord-analysis__label">Scale:</span> |
There was a problem hiding this comment.
Removed space after 'Scale:' in the label. The original had 'Scale: ' with a trailing space, but the formatted version removed it. This changes the visual spacing between the label and value. Consider keeping the space for consistency with typical label-value formatting patterns.
| {scale} | ||
| </div> | ||
| <div class="kord-chord-analysis__detail"> | ||
| <span class="kord-chord-analysis__label">Chord:</span> |
There was a problem hiding this comment.
Removed space after 'Chord:' in the label. The original had 'Chord: ' with a trailing space, but the formatted version removed it. This changes the visual spacing between the label and value. Consider keeping the space for consistency with typical label-value formatting patterns.
No description provided.