More benchmarks for creating bloom filters#672
Open
anish749 wants to merge 2 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #672 +/- ##
===========================================
+ Coverage 89.45% 89.52% +0.06%
===========================================
Files 113 113
Lines 8944 8944
Branches 490 490
===========================================
+ Hits 8001 8007 +6
+ Misses 943 937 -6
Continue to review full report at Codecov.
|
Contributor
|
by the way, I'm happy to merge this, but you never signed the CLA. Could you do that? |
Contributor
Author
|
Hello, I am extremely sorry I missed the CLA 🤦, I initially thought I already did it. |
Contributor
|
Yeah I think we add a similar case before where the status got stuck in the Pending phase ... couldn't find the PR where that happened though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some use cases in Scio we create large Bloom filters with around 5 ~ 50M entries in some batch data pipelines. We were using BloomFilterAggregator API for most of our uses cases, and it felt like a good idea to bench mark the aggregator for comparison.