Refresh override script cache before password overwrite in XCredsCreateUser - #382
Open
07-C9 wants to merge 1 commit into
Open
Refresh override script cache before password overwrite in XCredsCreateUser#38207-C9 wants to merge 1 commit into
07-C9 wants to merge 1 commit into
Conversation
|
Big +1 here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating this PR. After more testing, I realized the first version of the fix doesn't help if LAPS rotates while at the XCreds login window, and then a user goes to login with a changed IdP password.
Moved refreshCachedPrefs() to XCredsCreateUser, right before a password overwrite is needed. It only runs during PasswordOverwriteSilent when a password mismatch is detected, so normal logins are unaffected. Existing set-admin-user workflows are also unaffected.
Tested by rotating LAPS while at the login window, then logging in with a changed cloud password. Password overwrite succeeded with the post-rotation creds:
Without this fix, the same test fails with stale cached credentials.