Support non-sliceable containers in uniqueness assertions#165
Open
jeet-dekivadia wants to merge 1 commit into
Open
Support non-sliceable containers in uniqueness assertions#165jeet-dekivadia wants to merge 1 commit into
jeet-dekivadia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Allow
assertUniqueandassertNotUniqueto handle iterable containers that do not support slice indexing.Fixes #74.
Approach
Replace slice-based duplicate detection with a shared iterator-based helper. The helper keeps a list of previously seen elements, preserving support for unhashable values while also supporting containers such as
collections.deque.Tests for New Behavior
dequevalues with both assertionsgit diff --checkpython3 -m py_compile marbles/mixins/marbles/mixins/mixins.py marbles/mixins/tests/test_mixins.pypython3 -m unittest tests.test_mixins.TestUniqueMixinsChecklist
nox -s flake8to make sure code style is consistentLearning
The previous implementation intentionally avoided
set(container)so unhashable elements would work, but slice indexing narrowed support to sequence-like containers. Aseenlist keeps the original equality semantics without that indexing requirement.Remote Linux validation
git diff --checkpython -m compileall -q marbles/mixinspython -m unittest tests.test_mixins.TestUniqueMixins -v