Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to conditionally create Service resource #159

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add option to conditionally create Service resource #159

wants to merge 2 commits into from

Conversation

bwdmr
Copy link

@bwdmr bwdmr commented Mar 15, 2025 

- Add new parameter `service.create` (default: false) to control Service creation
- Wrap Service template in conditional to respect the new parameter
- Update documentation and default values to reflect this change

This allows users who don't need the Service resource (e.g., when using
Ingress directly or external service management) to skip its creation.

bwdmr added 2 commits March 15, 2025 09:17
@bwdmr
Refactor namespace handling in Docker registry Helm chart
cb49b7f 
- Create a reusable helper template "docker-registry.namespace" in _helpers.tpl
- Replace all instances of "{{ .Values.namespace | default .Release.Namespace }}"
  with "{{ include "docker-registry.namespace" . }}" for consistency
- Apply this change across all resource templates (deployment, service,
  configmap, secret, cronjob, pvc, etc.)

This refactoring improves maintainability and ensures consistent namespace
handling throughout the chart, particularly for multi-namespace deployments
in combined charts.
@bwdmr
Add option to conditionally create Service resource
6ec0776 
- Add new parameter `service.create` (default: false) to control Service creation
- Wrap Service template in conditional to respect the new parameter
- Update documentation and default values to reflect this change

This allows users who don't need the Service resource (e.g., when using
Ingress directly or external service management) to skip its creation.

Signed-off-by: bwdmr <[email protected]>
@bwdmr bwdmr force-pushed the conditionalservice branch from 4ba0d13 to 6ec0776 Compare March 15, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bwdmr