feat: starknet core integration -> main [STRK-01]#26
Open
ljankovic-txfusion wants to merge 16 commits intofeat/starknet-core-abi-exportsfrom
Open
feat: starknet core integration -> main [STRK-01]#26ljankovic-txfusion wants to merge 16 commits intofeat/starknet-core-abi-exportsfrom
ljankovic-txfusion wants to merge 16 commits intofeat/starknet-core-abi-exportsfrom
Conversation
| // setup contract factory | ||
| const overrides = this.getTransactionOverrides(chainNameOrId); | ||
| const signer = this.getSigner(chainNameOrId); | ||
| const contractFactory = await factory.connect(signer); |
Author
There was a problem hiding this comment.
not related to starknet - but await is not needed here
| } | ||
|
|
||
| export interface StarknetJsTransactionReceipt | ||
| extends TypedTransactionReceiptBase<StarknetTxReceipt | StarknetReceiptTx> { |
Author
There was a problem hiding this comment.
GetTransactionReceiptResponse encapsulates ReceiptTx and TransactionReceipt is not used
| return { gasUnits: 0, gasPrice: 0, fee: Number(defaultQuote.amount) }; | ||
| } | ||
|
|
||
| // TODO: DOES NOT WORK FOR STARKNET |
Author
There was a problem hiding this comment.
... yet, because starknet does not support gas estimation without starknet account
| symbol: atom | ||
| name: atom | ||
| addressOrDenom: atom | ||
| - chainName: starknetdevnet |
Author
There was a problem hiding this comment.
Had some tests in typescript/sdk/src/warp/WarpCore.test.ts for this token, but because gas estimation works differently in starknet & could not be stubbed, I had to ditch it
| }); | ||
| } else if ( | ||
| transaction.type === ProviderType.Starknet && | ||
| provider.type === ProviderType.Starknet |
Author
There was a problem hiding this comment.
Other protocols also check both the transaction and provider type
ljankovic-txfusion
changed the title
ljankovic-txfusion
changed the title
ljankovic-txfusion
changed the title
ljankovic-txfusion
changed the title
ljankovic-txfusion
force-pushed
the
feat/starknet-core-abi-exports
branch
from
ae03261 to
0eb975f
Compare
ljankovic-txfusion
force-pushed
the
feat/starknet-sdk-integration
branch
from
1cfeb65 to
f0d7677
Compare
…into feat/starknet-utils
…tarknet-sdk-integration
…into feat/starknet-utils
…tarknet-sdk-integration
### Description fix: changelog typos ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
### Description Updates the solana igp config to add abstract ### Drive-by changes no ### Related issues ### Backward compatibility ### Testing
…tion [STARKNET-01] (hyperlane-xyz#5830) ### Description 1st Starknet PR This PR adds the `@hyperlane-xyz/starknet-core` package for fetching Starknet contract ABI and generating contract artifacts. The package provides TypeScript tooling for interacting with Cairo contracts ABI on Starknet, including auto-generated compiled contract ABIs from Astraly Labs Hyperlane repo. ### Drive-by changes None ### Related issues Resolves ENG-1270 ### Backward compatibility This is a new package that doesn't modify existing functionality ### Testing Manual testing of contract fetching and artifact generation
### Description This PR adds the Turbo USD (tUSD) warp route from Ethereum to Eclipse. Client: Nucleus/Eclipse. ### Related issues - [Nucleus Deployment](https://www.notion.so/hyperlanexyz/Nucleus-1dd6d35200d680feb39cc050ed2e1059?pvs=4) ### Backward compatibility Yes ### Testing Testing only possible via UI as our CLI tools don't support EVM-SVM roundtrip transfers. The UI testing is not yet possible because the tUSD token on Ethereum is not fully configured.
…tarknet-sdk-integration
…yperlane-xyz#5851) ### Description 2nd Starknet PR This PR introduces utilities for starknet addresses. [Diff with previous PR - feat: Add Starknet contract ABI fetching and contract artifact generation hyperlane-xyz#5830](https://github.com/txfusion/hyperlane-monorepo/pull/27/files) ### Drive-by changes - Exports for starknet address from typescript/utils ### Related issues None ### Backward compatibility Yes ### Testing None
### Description fix: monorepo docker builds ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
…tarknet-sdk-integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR DIFF
This PR introduces Starknet logic to enable token warping on the UI.