PR history for both repos, with the diffs readable in place - #85
Merged
Merged
Conversation
Adds a collapsed History section under the open change requests on /prs, listing
merged requests from THIS flow in both the knowledge repo and Blueprint, each row
linking into the existing diff viewer rather than out to GitHub.
Provenance is the hard part, and the two repos have opposite problems: the
knowledge repo carries its own machinery work alongside review batches (81 of its
84 merged requests are machinery), and Blueprint is a shared docs repo with a lot
of unrelated traffic. So a request qualifies on EITHER of two markers:
* the `onetyler-review` LABEL, applied at creation on both repos. Authoritative,
and visible on GitHub itself rather than only through this tool.
* the BRANCH PREFIX -- `review/` and `kb-review/`. This covers the back-catalogue,
since the label only exists from today. `headRefName` survives the branch being
deleted at merge (verified on #84, whose branch 404s on the branches API while
the PR record still reports its name), so it stays readable indefinitely.
Either alone was insufficient: label-only would have shipped an empty history,
prefix-only leaves nothing identifiable on GitHub.
Tagging is never fatal. Labelling Blueprint may exceed a contributor's rights, and
the prefix keeps the request in the history regardless -- so a failure is reported
and the request is not re-opened. The label is created lazily, when a request is
opened, so viewing a dashboard never writes to Blueprint.
Also, in the diff viewer:
* `?full=1` lifts BOTH truncation caps, reached from the truncation notice itself.
The caps stay on by default, but "open it on GitHub" was the only escape from
them, which made them a dead end on exactly the large requests worth reading.
* Refresh now carries `repo` and `full`. It did neither, so refreshing a Blueprint
diff silently fetched the KNOWLEDGE request with the same number.
* A merged request said "closed", which reads as abandoned. It now says merged,
with the date and who merged it.
The three historical review batches (#18, #31, #47) were labelled by hand so the
label is authoritative from the start rather than only for future requests.
Verified: the filter picks exactly those 3 of 84 merged requests and no duplicates
when both markers match; both caps confirmed lifted by `full=1` against forced
limits (12 lines/3 files on #18: 12 -> 323 lines, 3 -> 28 files); a bad Blueprint
number renders an error page rather than crashing; contrast green.
Claude-Session: https://claude.ai/code/session_01VVNYqGza2dFdeWFX7qXnwb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a collapsed History section under the open change requests on /prs, listing
merged requests from THIS flow in both the knowledge repo and Blueprint, each row
linking into the existing diff viewer rather than out to GitHub.
Provenance is the hard part, and the two repos have opposite problems: the
knowledge repo carries its own machinery work alongside review batches (81 of its
84 merged requests are machinery), and Blueprint is a shared docs repo with a lot
of unrelated traffic. So a request qualifies on EITHER of two markers:
onetyler-reviewLABEL, applied at creation on both repos. Authoritative,and visible on GitHub itself rather than only through this tool.
review/andkb-review/. This covers the back-catalogue,since the label only exists from today.
headRefNamesurvives the branch beingdeleted at merge (verified on Professional register, compact: hints on screen, not documentation #84, whose branch 404s on the branches API while
the PR record still reports its name), so it stays readable indefinitely.
Either alone was insufficient: label-only would have shipped an empty history,
prefix-only leaves nothing identifiable on GitHub.
Tagging is never fatal. Labelling Blueprint may exceed a contributor's rights, and
the prefix keeps the request in the history regardless -- so a failure is reported
and the request is not re-opened. The label is created lazily, when a request is
opened, so viewing a dashboard never writes to Blueprint.
Also, in the diff viewer:
?full=1lifts BOTH truncation caps, reached from the truncation notice itself.The caps stay on by default, but "open it on GitHub" was the only escape from
them, which made them a dead end on exactly the large requests worth reading.
repoandfull. It did neither, so refreshing a Blueprintdiff silently fetched the KNOWLEDGE request with the same number.
with the date and who merged it.
The three historical review batches (#18, #31, #47) were labelled by hand so the
label is authoritative from the start rather than only for future requests.
Verified: the filter picks exactly those 3 of 84 merged requests and no duplicates
when both markers match; both caps confirmed lifted by
full=1against forcedlimits (12 lines/3 files on #18: 12 -> 323 lines, 3 -> 28 files); a bad Blueprint
number renders an error page rather than crashing; contrast green.
Claude-Session: https://claude.ai/code/session_01VVNYqGza2dFdeWFX7qXnwb