fix/mark pushed refreshes index - #98
Merged
Merged
Conversation
vijay-tylertech
commented
Sep 4, 2026
vijay-tylertech
commented
Contributor
- Reviews by Vijay Venkataraman — 09032026-071659
- mark_pushed.py: refresh INDEX.md itself instead of asking the human to
This script rewrites `review_status` in every transcript it closes out, which is
exactly what INDEX.md summarises -- so leaving the index stale is not untidiness, it
is a CI failure on the next pull request. `validate` regenerates the index and fails
if it differs.
Observed twice, and both times read as somebody's mistake rather than a missing step:
* run 33260021601 (verdict revert) -- one row out
* run 33888825829 (Jon closing out 11 transcripts) -- header still claimed
"11 reviewed, 16 pushed" where the frontmatter now said "0 reviewed, 27 pushed"
It ended with `print("Next: python3 scripts/review_status.py")`. A printed reminder is
not a mechanism: the whole point of closing out a batch is that it is the last thing
you do, so there is nothing afterwards to prompt you. The review server has always
called review_status.py itself after a write (refresh_index()); this is the CLI
equivalent, and mark_pushed is the only CLI path that changes review_status.
A refresh that fails is reported, not fatal -- the close-out itself already succeeded
and is on disk, and saying so beats the silent stale index this replaces.
Verified in an isolated worktree on Jon's branch f94c233, reproducing his close-out of
11 transcripts and then running validate's exact check (regenerate, then
`git diff --quiet -- transcripts/INDEX.md`): old script FAIL, new script PASS.
Note fetch_transcripts.py and publish_to_foundry.py also only mention the command.
Neither writes `review_status`, so neither can stale the index this way; left alone.
Claude-Session: https://claude.ai/code/session_01VVNYqGza2dFdeWFX7qXnwb
vijay-tylertech
added a commit
that referenced
this pull request
Sep 4, 2026
The 11 table rows were resolved correctly; only the generated summary line kept the pre-close-out side of the conflict, so it read "11 reviewed, 16 pushed" while the frontmatter said "0 reviewed, 27 pushed". `validate` regenerates the index and compares, so the single stale line failed the whole run (33888825829). Regenerated with `python3 scripts/review_status.py` rather than hand-edited — it is a generated file and the generator is the only thing that should write it. No other file in the tree moved, and no verdict was touched. The step that made this possible is gone as of #98: mark_pushed.py now regenerates the index itself instead of printing "Next: python3 scripts/review_status.py". This was the last request that could hit it. Claude-Session: https://claude.ai/code/session_01VVNYqGza2dFdeWFX7qXnwb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.