Update exports for Typescript 2.6 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typescript 2.6 removed support for default exports of a declared object, as was done previously in this file. This change could be made backwards compatible by adding a default export with the old default members, but it seems better to avoid the default export functions which are already exported.
|
Don't see why not. cc @felixfbecker @blakeembrey |
|
alternative workaround here, if default export is necessary https://stackoverflow.com/questions/47094210/d-ts-not-compiling-after-typescript-2-6-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript 2.6+ does not allow the default export that's currently in these types, so this PR removes the default export.
If it's preferred, I could also add a default export class or namespace which contains the 3 functions the original did to maintain backwards compatibility for anyone using the default export.
I also added the
closeConnection()method to theGremlinClientso you can actually close the connection in Typescript without using a type assertion as a workaround.