Test castable value types for annotations #395
+385
−350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingsilverfin
commented
Dec 22, 2025
Comment on lines
-194
to
-196
| | date | 2024-05-04 | | ||
| | datetime | 2024-05-04 | | ||
| | datetime-tz | 2024-05-04+0010 | |
Member
Author
There was a problem hiding this comment.
BDD parser has been updated in Core - and TypeQL doesn't allow eliding the T00:00 from timezone-datetimes. If you have a datetime, you can accept a literal without T00:00, since it's parsed as a DateLiteral, which is trivially castable to datetime.
flyingsilverfin
commented
Dec 22, 2025
| | decimal | 0.0dec..100.0dec | integer | 150 | 50 | | ||
| | decimal | 0.0dec..100.0dec | integer | -10 | 0 | | ||
| | decimal | 0.0dec..100.0dec | integer | 101 | 100 | | ||
| # TODO decimals and doubles don't go cleanly into integers, so that isn't allowed? |
Member
Author
There was a problem hiding this comment.
@range value arguments should be exactly the right types, or trivially castable - not sometimes castable (eg. some doubles go into integer, and some decimals go into integer, but not always)
Member
Author
There was a problem hiding this comment.
If we all agree, will delete this set of test rows
flyingsilverfin
commented
Dec 22, 2025
| | double | 0.01 | 0.1 | 0.01 | | ||
| | double | 0.01, 0.0001 | 0.001 | 0.0001 | | ||
| | double | 0.01, 0.0001 | 1.0 | 0.01 | | ||
| | decimal | -8.0, 88.3, 0.001 | 0.01 | 0.001 | |
Member
Author
There was a problem hiding this comment.
Update: double is not always castable into decimal, so we require using the decimal or integer syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage and product changes
We add tests for using castable value types for setting @value and @range annotations. We now align to the behaviour that:
Annotation arguments must match value type exactly, or be losslessly castable values:
This means lots of tests changed to require
T:00:00fordatetime-tzvalues, and no longer allow doubles to be castable intodecimalin our tests.