Poll on the 0th tick, check external queue on 32nd #4270
+46
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Feb 8, 2025
Comment on lines
+765
to
+766
| if ((tick & ExternalWorkTicksMask) == 0) { | ||
| if ((tick & PollingTicksMask) == 0) { |
There was a problem hiding this comment.
There's a couple ways we could encode this 🤷
Also, random idea: what if we just completely unrolled the 64 ticks of the worker loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the worker thread runloop so that I/O polling and external queue polling are no longer part of the same tick, and instead occur at opposite ends of the loop i.e. the 0th and 32nd ticks. The goal is to reduce the chance that the local queue overflows, by giving it a chance to work on tasks in-between polling these sources.