fixed Private key and certificates on repo #3666
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptapratykshh
changed the title
guptapratykshh
force-pushed
the
fix/ephemeral-certificates-issue-3611
branch
3 times, most recently
from
c718b27 to
be002a5
Compare
Signed-off-by: guptapratykshh <[email protected]>
guptapratykshh
force-pushed
the
fix/ephemeral-certificates-issue-3611
branch
from
be002a5 to
00b9144
Compare
Author
|
@mpilquist can you have a look at this PR , Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3611
Removed the static key.pem and cert.pem files from io/shared/src/test/resources to verify we are no longer relying on committed private keys , implemented ephemeral certificate generation for Scala Native using the openssl CLI. This generates a proper Root CA and signs a Server Certificate with strict RFC 5280 extensions (SKI, AKI, KeyUsage) to satisfy s2n-tls validation requirements and implemented ephemeral certificate generation for Scala.js using openssl (via fs2.io.process), ensuring we can run TLS tests on Node.js without the deleted static files.