feat(stemming): add stemming dictionary management support #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonbosco
requested changes
Feb 5, 2025
It was because of the Typesense version on the CI pipeline |
- add `Stemming`, `StemmingDictionaries`, and `StemmingDictionary` classes - implement dictionary upsert and retrieve operations - add client support for stemming feature - add tests for dictionary operations
- add null check in `StemmingDictionaries::retrieve()` to return empty dict - add setup method to initialize dictionary before tests - fix typo in test method name from `Rules` to `Dictionaries`
tharropoulos
force-pushed
the
v28-changes
branch
2 times, most recently
from
832d91a to
1e28547
Compare
tharropoulos
force-pushed
the
v28-changes
branch
from
1e28547 to
38a8f65
Compare
jasonbosco
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This pull request introduces a new feature for managing stemming dictionaries in the client, introduced as part of the upcoming v28 release. The changes include adding new classes for stemming functionality, updating the
Clientclass to incorporate stemming, and adding tests for the new feature.Stemming functionality:
src/Client.php: Added a newStemmingproperty and corresponding getter method to theClientclass. Updated the constructor to initialize theStemmingproperty.src/Stemming.php: Introduced a newStemmingclass with methods to manage stemming dictionaries.src/StemmingDictionaries.php: Added aStemmingDictionariesclass implementingArrayAccessto manage individual stemming dictionaries.src/StemmingDictionary.php: Created aStemmingDictionaryclass to handle operations on individual stemming dictionaries.Tests:
tests/Feature/StemmingDictionariesTest.php: Added tests to verify the functionality of upserting and retrieving stemming dictionaries.- addStemming,StemmingDictionaries, andStemmingDictionaryclassesPR Checklist