Fix HTTP Client Type Handling in API Calls #86
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
Support both PSR-18 ClientInterface and HttpMethodsClient implementations in API calls.
Change Summary
What is this?
This change addresses a critical compatibility issue where the Typesense PHP client was not properly handling different HTTP client implementations. Users were encountering errors when trying to use standard PSR-18 compatible clients, limiting the library's flexibility and causing unexpected failures. This fix enables broader compatibility with different HTTP client implementations while maintaining existing functionality.
Changes
Code Improvements:
In
src/ApiCall.php
:$client
property to support bothClientInterface
andHttpMethodsClient
typesClientInterface
implementationsIn
src/Lib/Configuration.php
:getClient()
method to support both client typesTechnical Details:
ClientInterface
HttpMethodsClient
implementationContext
This change addresses two reported issues:
The fix ensures that users can now use any PSR-18 compatible client implementation without encountering type errors, while maintaining support for the existing
HttpMethodsClient
functionality. This improvement makes the library more flexible and robust, following PHP-FIG standards for HTTP client implementations.PR Checklist